aboutsummaryrefslogtreecommitdiffstats
path: root/README.multi-tty
diff options
context:
space:
mode:
authorKaroly Lorentey <[email protected]>2005-09-11 06:42:03 +0000
committerKaroly Lorentey <[email protected]>2005-09-11 06:42:03 +0000
commit256c9c3a61a5a2c5d394277f5b0f25adb453771d (patch)
tree897024a7092e469356b80c07dae3dbeb045d7e7c /README.multi-tty
parentee0bcfbce6e8f7055f483976a68b33a2bdd46d14 (diff)
Fix crash after y-or-n-p prompt triggered by emacsclient. (Reported by Han Boetes, analysis by Kalle Olavi Niemitalo.)
* src/keyboard.c (temporarily_switch_to_single_kboard) (record_single_kboard_state, restore_kboard_configuration): New functions. (timer_check): Use record_single_kboard_state instead of naive single_kboard state management. * src/fns.c: Include termhooks.h. (Fy_or_n_p): Use temporarily_switch_to_single_kboard to prevent crashes caused by bogus longjmps in read_char. * src/callint.c (Fcall_interactively): Use temporarily_switch_to_single_kboard instead of single_kboard_state. Make sure it is correctly unwinded. * src/keyboard.c (recursive_edit_unwind): Remove single_kboard stuff. (Frecursive_edit): Use temporarily_switch_to_single_kboard for single_kboard state management. * src/minibuf.c (read_minibuf): Use temporarily_switch_to_single_kboard instead of simply calling single_kboard_state. * src/keyboard.c (push_device_kboard): Remove function. (push_kboard): New function. (push_frame_kboard): Use it. (pop_frame_kboard): Rename to pop_kboard. * src/xdisp.c (display_mode_line, Fformat_mode_line): Update uses. * src/data.c: Include termhooks.h. (Fterminal_local_value, Fset_terminal_local_value): Update. * src/Makefile.in (data.o, fns.o): Add termhooks.h dependency. * src/keyboard.h (push_device_kboard, pop_frame_kboard): Remove declarations. (push_kboard, pop_kboard, temporarily_switch_to_single_kboard) (record_single_kboard_state): New declarations. git-archimport-id: [email protected]/emacs--multi-tty--0--patch-414
Diffstat (limited to 'README.multi-tty')
-rw-r--r--README.multi-tty70
1 files changed, 38 insertions, 32 deletions
diff --git a/README.multi-tty b/README.multi-tty
index 9dc7f6b8bd..931769ea50 100644
--- a/README.multi-tty
+++ b/README.multi-tty
@@ -31,27 +31,28 @@ The following is a (sadly incomplete) list of people who have
contributed to the project by testing, submitting patches, bug
reports, and suggestions. Thanks!
-ARISAWA Akihiro <ari at mbf dot ocn dot ne dot jp>
-Vincent Bernat <bernat at luffy dot cx>
-Han Boetes <han at mijncomputer dot nl>
-Robert J. Chassell <bob at rattlesnake dot com>
-Romain Francoise <romain at orebokech dot com>
-Ami Fischman <ami at fischman dot org>
-Friedrich Delgado Friedrichs <friedel at nomaden dot org>
-IRIE Tetsuya <irie at t dot email dot ne dot jp>
-Yoshiaki Kasahara <kasahara at nc dot kyushu-u dot ac dot jp>
-Bas Kok <nekkobassu at yahoo dot com>
-Jurej Kubelka <Juraj dot Kubelka at email dot cz>
-David Lichteblau <david at lichteblau dot com>
-Xavier Mallard <zedek at gnu-rox dot org>
-Istvan Marko <mi-mtty at kismala dot com>
-Ted Morse <morse at ciholas dot com>
-Dan Nicolaescu <dann at ics dot uci dot edu>
-Gergely Nagy <algernon at debian dot org>
-Mark Plaksin <happy at mcplaksin dot org>
-Francisco Borges <borges at let dot rug dot nl>
-Frank Ruell <stoerte at dreamwarrior dot net>
-Dan Waber <dwaber at logolalia dot com>
+ARISAWA Akihiro <[email protected]>
+Vincent Bernat <[email protected]>
+Han Boetes <[email protected]>
+Robert J. Chassell <[email protected]>
+Romain Francoise <[email protected]>
+Ami Fischman <[email protected]>
+Friedrich Delgado Friedrichs <[email protected]>
+IRIE Tetsuya <[email protected]>
+Yoshiaki Kasahara <[email protected]>
+Jurej Kubelka <[email protected]>
+David Lichteblau <[email protected]>
+Xavier Mallard <[email protected]>
+Istvan Marko <[email protected]>
+Ted Morse <[email protected]>
+Gergely Nagy <[email protected]>
+Dan Nicolaescu <[email protected]>
+Kalle Olavi Niemitalo <[email protected]>
+Mark Plaksin <[email protected]>
+Francisco Borges <[email protected]>
+Frank Ruell <[email protected]>
+Dan Waber <[email protected]>
and many others.
Richard Stallman was kind enough to review an earlier version of my
@@ -387,17 +388,8 @@ is probably not very interesting for anyone else.)
THINGS TO DO
------------
-** This long-standing bug (first reported by Han Boetes) seems to come
- and go all the time. It is time to track it down and fix it.
-
- emacs
- M-x server-start
-
- # From another xterm:
- emacsclient -e '(y-or-n-p "Do you want me to crash? ")'
- # Notice how the answer ends up in the *scratch* buffer
- M-x garbage-collect
- SIGSEGV
+** Report GTK multi-display problems to GTK maintainers. For extra
+ credit, fix them.
** frames-on-display-list should also accept frames.
@@ -1239,5 +1231,19 @@ DIARY OF CHANGES
(I think patch-370 fixed this.)
+-- This long-standing bug (first reported by Han Boetes) seems to come
+ and go all the time. It is time to track it down and fix it.
+
+ emacs
+ M-x server-start
+
+ # From another xterm:
+ emacsclient -e '(y-or-n-p "Do you want me to crash? ")'
+ # Notice how the answer ends up in the *scratch* buffer
+ M-x garbage-collect
+ SIGSEGV
+
+ (Fixed in patch-414 after detailed analysis by Kalle Olavi Niemitalo.)
+
;;; arch-tag: 8da1619e-2e79-41a8-9ac9-a0485daad17d