aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard M. Stallman <[email protected]>2005-05-30 06:49:18 +0000
committerRichard M. Stallman <[email protected]>2005-05-30 06:49:18 +0000
commitcbd87c94ac75cbc30b069dd56af48b30ab2952b0 (patch)
tree14488754bf53dc5c56c471d70072af753fd5b34a
parentaf3f7411df31f32e1c26eea1ce67f4239a3989b1 (diff)
(byte-compile-nogroup-warn): Warn only when name to be defined is quoted.
-rw-r--r--lisp/emacs-lisp/bytecomp.el18
1 files changed, 9 insertions, 9 deletions
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index e5b429604c..3948dae610 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1248,15 +1248,15 @@ extra args."
(defun byte-compile-nogroup-warn (form)
(let ((keyword-args (cdr (cdr (cdr (cdr form)))))
(name (cadr form)))
- (unless (plist-get keyword-args :group)
- (byte-compile-warn
- "%s for `%s' fails to specify containing group"
- (cdr (assq (car form)
- '((custom-declare-group . defgroup)
- (custom-declare-face . defface)
- (custom-declare-variable . defcustom))))
- (if (and (consp name) (eq (car name) 'quote))
- (cadr name) name)))))
+ (or (plist-get keyword-args :group)
+ (not (and (consp name) (eq (car name) 'quote)))
+ (byte-compile-warn
+ "%s for `%s' fails to specify containing group"
+ (cdr (assq (car form)
+ '((custom-declare-group . defgroup)
+ (custom-declare-face . defface)
+ (custom-declare-variable . defcustom))))
+ (cadr name)))))
;; Warn if the function or macro is being redefined with a different
;; number of arguments.