From f3f3bc148c4d2221ceb12ef67d14db6e8b8300c7 Mon Sep 17 00:00:00 2001 From: Thanos Apollo Date: Sun, 3 Mar 2024 03:40:28 +0200 Subject: gnosis-algorithm-next-ef: Fix assertions --- gnosis-algorithm.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gnosis-algorithm.el b/gnosis-algorithm.el index 991a6d1..90ea7d5 100644 --- a/gnosis-algorithm.el +++ b/gnosis-algorithm.el @@ -130,10 +130,11 @@ reviews, increase ef-increase by INCREASE. For every THRESHOLD of C-FAILURES reviews, decrease ef-decrease value by DECREASE." - (cl-loop for (param type) in '((ef listp) (success booleanp) (increase numberp) - (decrease numberp) (threshold numberp)) - do (cl-assert (funcall type (symbol-value param)) nil - "Assertion failed: %s must be of type %s" param type)) + (cl-assert (listp ef) nil "Assertion failed: ef must be a list") + (cl-assert (booleanp success) nil "Assertion failed: success must be a boolean value") + (cl-assert (numberp increase) nil "Assertion failed: increase must be a number") + (cl-assert (numberp decrease) nil "Assertion failed: decrease must be a number") + (cl-assert (numberp threshold) nil "Assertion failed: threshold must be a number") (let ((threshold-p (= (% (max 1 (if success c-successes c-failures)) threshold) 0)) (new-ef (if success (gnosis-algorithm-replace-at-index 2 (+ (nth 2 ef) (nth 0 ef)) ef) (gnosis-algorithm-replace-at-index 2 (max 1.3 (- (nth 2 ef) (nth 1 ef))) ef)))) -- cgit v1.2.3