Age | Commit message (Collapse) | Author |
|
|
|
This reverts commit 2473e9127a8f8ece2bcb1052d5450834bbbbb4c8.
During the this pull request on MELPA
<https://github.com/melpa/melpa/pull/8890>
Nicholas Vollmer pointed out that length= does not exist in Emacs <
28.1, but since we are using compat we can still use it.
This was also suggested by Philip Kaludercic in this email in
emacs-devel:
<https://lists.gnu.org/archive/html/emacs-devel/2024-01/msg00682.html>
I verified this by running emacs-27.2, length= was available thanks to
compat
|
|
Changes suggested by Philip Kaludercic via the emacs-devel mailing
list
<https://lists.gnu.org/archive/html/emacs-devel/2024-01/msg00682.html>
Philip pointed out that gnosis relies heavily on completing-read for
user interactions, but for users that do not use completion packages
such as vertico it's inconvenient to say the least. This should be
addressed.
Another important change was making gnosis-add-note more extensible.
Adding your own custom note types should be easier now as well as the
maintainability.
Many of the changes made here are not tested properly.
Merging into testing branch for further review and refactoring.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- Added `gnosis-note-types` variable to store available note
types (MCQ, Cloze, Basic, Double, y-or-n)
- Updated `gnosis-add-note` function to dynamically call corresponding
note creation functions based on selected type
- Updated interactive prompt in `gnosis-add-note` to display available
note types
This commit enhances the flexibility & extensibility of note creation
|
|
- Updated gnosis-dir to use `locate-user-emacs-file` for consistent file location
- Updated gnosis-images-dir to use `expand-file-name` for consistent filepath
- Updated gnosis-db to use `expand-file-name` for consistent filepath in emacsql-sqlite initialization
|
|
- Add documentation
- Fix docstrings & types of custom vars
Improve algorithm implementation
- Adjust next ef and interval depending on consecutive & total
failures/successes
- Fix bugs for custom reviews where last-interv would be 0
|
|
|
|
|
|
|
|
|
|
Documentation is generated from gnosis.org
|
|
- Make sure note id value will not be changed
Change suggested by Nicholas Vollmer
|
|
- No need to have them as 'hidden' with double dash (--)
Change suggested by Nicholas Vollmer
|
|
Fix quotes
|
|
No need to warn user not to change the value of a defconst
Change suggested by Nicholas Vollmer
|
|
Change suggested by Nicholas Vollmer
|
|
cl-loop's do clause is an implicit progn.
|
|
Length= is available only for Emacs 28.1 >
Pointed out by Nicholas Vollmer
|
|
- Make sure it's not above 0.8, unless user is using failure factor > 8
|
|
- Add type for list
|
|
- Use keywords!
- Add argument for initial-interval, successful-reviews,
successful-reviews-c, fails-c, fails-t
- Use initial-interval which is could be different for every note,
instead of gnosis-algorithm-interval value.
- Depending on the value of new arguments for total/consecutive
fails/successful reviews calculate a different interval.
|
|
- Minor updates on commentary & docstrings, using checkdoc
With this version gnosis should meet the requirments to be included on
MELPA
|
|
|
|
|
|
|
|
|
|
|
|
- Fix bug for multiple clozes review
- Fix gnosis-review-y-or-n for new inputs
- Update gnosis-algorithm implementation
- Fix minor bugs on gnosis-algorithm
Reviews for all note types should work fine with this version
|
|
|
|
|
|
- Update note after all clozes have been revealed and add comment as reminder
|
|
Previous implementation was using total successful reviews in a row
|
|
|
|
- Fix review of y-or-n type
|
|
- Remove previous unused user-input keyword
- Fix name typo
|
|
This is marks the first "release" of gnosis, it's still under heavy
development, but the fundamental use is there. More features will be
added in the future, that should not affect notes created using this
version.
|
|
|
|
Adding note type of y-or-n and fixing issues with with
gnosis-edit-mode
y-or-n type note is one that has an answer value of char y or n.
|
|
Having gnosis-edit-mode-map defined after gnosis-edit-mode does not
work, it needs to be defined before
|
|
|
|
Display answer for note with face depending on the value of success
|
|
Functions to add note type y-or-n,
gnosis-add-note--y-or-n is the hidden function that interacts with
gnosis-add-note-fields & gnosis-add-note-y-or-n that passes values interactively
|
|
- This could occur in custom review sessions, option should be added
to have the same for success 0, but I didn't have any issues _yet_,
will revisit this soon
- Update docstrings & add comments for this
- Fix successful-reviews value
|