summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThanos Apollo <[email protected]>2024-05-27 06:02:48 +0300
committerThanos Apollo <[email protected]>2024-05-27 06:13:12 +0300
commit0d66e03b1e4ad7c06e235eb199fa18cf4e7cb7fb (patch)
treed7312d9a3fbce8338f4327cd09636d0813bd3219
parent9b8b9704b7ae1bf4aa15ae0121fe79fa9a743316 (diff)
[fix] gnosis-algorithm: Use notes total-ef
-rw-r--r--gnosis-algorithm.el5
-rw-r--r--gnosis.el2
2 files changed, 2 insertions, 5 deletions
diff --git a/gnosis-algorithm.el b/gnosis-algorithm.el
index 075e669..33e3232 100644
--- a/gnosis-algorithm.el
+++ b/gnosis-algorithm.el
@@ -182,10 +182,7 @@ reviews. Will be used to determine the next interval for the first 2
successful reviews."
(cl-assert (< gnosis-algorithm-ff 1) "Value of `gnosis-algorithm-ff' must be lower than 1")
;; This should only occur in testing env or when the user has made breaking changes.
- (cl-assert (> (nth 2 ef) 1) "Total ef value must be above 1")
- (let* ((ef (nth 2 gnosis-algorithm-ef))
- ;; If last-interval is 0, use 1 instead.
- (last-interval (if (<= last-interval 0) 1 last-interval))
+ (let* ((last-interval (if (<= last-interval 0) 1 last-interval)) ;; If last-interval is 0, use 1 instead.
(interval (cond ((and (= successful-reviews 0) success)
(car initial-interval))
((and (= successful-reviews 1) success)
diff --git a/gnosis.el b/gnosis.el
index bf67962..5480a4d 100644
--- a/gnosis.el
+++ b/gnosis.el
@@ -1145,7 +1145,7 @@ Returns a list of the form ((yyyy mm dd) (ef-increase ef-decrease ef-total))."
;; (last-interval (max (gnosis-review--get-offset id) 1))
(last-interval (gnosis-review-last-interval id))) ;; last interval
(list (gnosis-algorithm-next-interval :last-interval last-interval
- :ef ef
+ :ef (nth 2 ef) ;; total ef is used for next interval
:success success
:successful-reviews t-success
:failure-factor ff