From 1d64afbdc0644a2be8bd2ad157085731e212ab74 Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Sun, 24 Nov 2019 20:47:20 +0100 Subject: tests: Avoid (catch 'srfi-34 …) form. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * tests/build-utils.scm ("wrap-script, raises condition"): Use 'guard' instead of "catch 'srfi-34". --- tests/build-utils.scm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'tests/build-utils.scm') diff --git a/tests/build-utils.scm b/tests/build-utils.scm index 61e6c44e63..ec442c267b 100644 --- a/tests/build-utils.scm +++ b/tests/build-utils.scm @@ -235,13 +235,11 @@ (define-module (test-build-utils) (lambda (port) (format port "This is not a script"))) (chmod script-file-name #o777) - (catch 'srfi-34 - (lambda () - (wrap-script script-file-name - #:guile "MYGUILE" - `("GUIX_FOO" prefix ("/some/path" - "/some/other/path")))) - (lambda (type obj) - (wrap-error? obj))))))) + (guard (c ((wrap-error? c) #t)) + (wrap-script script-file-name + #:guile "MYGUILE" + `("GUIX_FOO" prefix ("/some/path" + "/some/other/path"))) + #f))))) (test-end) -- cgit v1.2.3 From f5698dfb87df1132ca5c73a8ed7f75f63c07669f Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Sun, 24 Nov 2019 20:48:11 +0100 Subject: tests: Avoid unnecessary use of 'mock'. * tests/build-utils.scm ("wrap-script, simple case"): Use the real 'which' instead of mocking it. --- tests/build-utils.scm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'tests/build-utils.scm') diff --git a/tests/build-utils.scm b/tests/build-utils.scm index ec442c267b..47a57a984b 100644 --- a/tests/build-utils.scm +++ b/tests/build-utils.scm @@ -151,11 +151,12 @@ (define-module (test-build-utils) (test-equal "wrap-script, simple case" (string-append (format #f "\ -#!GUILE --no-auto-compile +#!~a --no-auto-compile #!#; Guix wrapper #\\-~s #\\-~s " + (which "guile") '(begin (let ((current (getenv "GUIX_FOO"))) (setenv "GUIX_FOO" (if current @@ -175,11 +176,9 @@ (define-module (test-build-utils) (lambda (port) (format port script-contents))) (chmod script-file-name #o777) - - (mock ((guix build utils) which (const "GUILE")) - (wrap-script script-file-name - `("GUIX_FOO" prefix ("/some/path" - "/some/other/path")))) + (wrap-script script-file-name + `("GUIX_FOO" prefix ("/some/path" + "/some/other/path"))) (let ((str (call-with-input-file script-file-name get-string-all))) (with-directory-excursion directory (delete-file "foo")) -- cgit v1.2.3